Messages in this thread | | | Date | Mon, 4 Jun 2007 18:20:58 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [patch 9/9] Scheduler profiling - Use conditional calls |
| |
* William Lee Irwin III (wli@holomorphy.com) wrote: > On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote: > >>> + if (prof_on) > >>> + BUG_ON(cond_call_arm("profile_on")); > > * William Lee Irwin III (wli@holomorphy.com) wrote: > >> What's the point of this BUG_ON()? The condition is a priori impossible. > > On Thu, May 31, 2007 at 05:12:58PM -0400, Mathieu Desnoyers wrote: > > Not impossible: hash_add_cond_call() can return -ENOMEM if kmalloc lacks > > memory. > > Shouldn't it just propagate the errors like anything else instead of > going BUG(), then? One can easily live without profiling if the profile > buffers should fail to be allocated e.g. due to memory fragmentation. > > These things all have to handle errors for hotplugging anyway AIUI. >
Cond call arming will not reserve memory anymore in the next release. (hash table is gone).
-- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |