Messages in this thread | | | Subject | Re: [PATCH] add a trivial patch style checker | From | Andi Kleen <> | Date | 30 May 2007 01:21:36 +0200 |
| |
Heiko Carstens <heiko.carstens@de.ibm.com> writes: > > I'm talking of a specific problem where we just added a panic to the > zfcp device driver. If that panic ever triggers we know for sure that > memory corruption happened. > So I'm just asking to not say in general that panic() in a device driver > is a bad thing.
Ok there might be exceptions, but in general I still think it's true. It probably fits the "you must be able to justify any warnings" rule. I would still like this check to be added.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |