lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!
    On Wed,  4 Apr 2007 14:05:04 -0400 Tony Lindgren wrote:

    > +static int __init fpga_init(void)
    > +{
    > + if (machine_is_omap_h4()
    > + || machine_is_omap_h3()
    > + || machine_is_omap_h2()
    > + || machine_is_omap_perseus2()
    > + )

    Perhaps there is nothing in CodingStyle for if () continuation
    lines. Looks like it is needed. This is ETOOMUCHINDENTATION by
    at least one tab. Should be more like:

    + if (machine_is_omap_h4()
    + || machine_is_omap_h3()
    + || machine_is_omap_h2()
    + || machine_is_omap_perseus2())


    (without getting into where the "||" should be placed).

    > + return platform_driver_register(&led_driver);
    > + return 0;
    > +}
    > +fs_initcall(fpga_init);

    fs, eh?

    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-04 21:07    [W:0.023 / U:0.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site