lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

On Apr 4 2007 12:00, Randy Dunlap wrote:
>
>> +static int __init fpga_init(void)
>> +{
>> + if (machine_is_omap_h4()
>> + || machine_is_omap_h3()
>> + || machine_is_omap_h2()
>> + || machine_is_omap_perseus2()
>> + )
>
>Perhaps there is nothing in CodingStyle for if () continuation
>lines. Looks like it is needed. This is ETOOMUCHINDENTATION by
>at least one tab. Should be more like:
>
>+ if (machine_is_omap_h4()
>+ || machine_is_omap_h3()
>+ || machine_is_omap_h2()
>+ || machine_is_omap_perseus2())

My stance, || goes at EOL, and final ) not standalone:

if (foo ||
bar ||
baz ||
etc)
do_something;



Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-04 22:11    [W:0.272 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site