lkml.org 
[lkml]   [2007]   [Mar]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 6 Mar 2007 09:05:09 +0100
FromPavel Machek <>
SubjectRe: [PATCH 1/3] libata: add missing PM callbacks
Hi!

> [cc'ing Pavel and linux-kernel, hello]> > Original thread can be read from> > http://thread.gmane.org/gmane.linux.ide/16475> > Jeff Garzik wrote:> > Tejun Heo wrote:> >> Some LLDs were missing scsi device PM callbacks while having host/port
> >> suspend support.  Add missing ones.> >>> >> Signed-off-by: Tejun Heo <htejun@gmail.com>> > > > applied 1-3, though I agree with Alan that a non-ifdef solution should
> > be sought (by the PM & PCI people?), where possible> > Agreed, CONFIG_PM ifdefs are all over low level drivers, libata or not,
> and ugly as hell.  Maybe use separate section, mark functions with
> __power and drop them at link time is a better idea.  With linker
> tricks, we can make references to __power symbols NULL.  How does it sound?

Much complexity for little gain. Who is running _without_ CONFIG_PM
these days?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-06 09:09    [from the cache]
©2003-2008