Messages in this thread | | | Date | Sat, 03 Mar 2007 12:11:05 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 1/3] libata: add missing PM callbacks |
| |
[cc'ing Pavel and linux-kernel, hello]
Original thread can be read from
http://thread.gmane.org/gmane.linux.ide/16475
Jeff Garzik wrote: > Tejun Heo wrote: >> Some LLDs were missing scsi device PM callbacks while having host/port >> suspend support. Add missing ones. >> >> Signed-off-by: Tejun Heo <htejun@gmail.com> > > applied 1-3, though I agree with Alan that a non-ifdef solution should > be sought (by the PM & PCI people?), where possible
Agreed, CONFIG_PM ifdefs are all over low level drivers, libata or not, and ugly as hell. Maybe use separate section, mark functions with __power and drop them at link time is a better idea. With linker tricks, we can make references to __power symbols NULL. How does it sound?
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |