Messages in this thread | | | Subject | Re: [PATCH 01 of 33] IB/ipath - add ability to set and clear IB local loopback | From | Roland Dreier <> | Date | Mon, 19 Mar 2007 14:22:56 -0700 |
| |
This patch format is somewhat inconvenient:
> # HG changeset patch > # User Bryan O'Sullivan <bos@pathscale.com>
I assume this is the real author of the patch (as opposed to the sender of the email)? git would prefer to see
From: Bryan O'Sullivan <bos@pathscale.com>
in the body of the email.
> # Date 1173994464 25200 > # Node ID b1d05f3486f8bba1dd3c5cbca39f06a5e1b3d6fb > # Parent 0d37971d4ab0c8b6f7a8f6e8222112321982498f
And all of these "#" lines get put into the patch description.
> IB/ipath - add ability to set and clear IB local loopback
No need to duplicate the subject line.
And incidentally, it would be better to use "IB/ipath: " instead of "IB/ipath -" as a prefix, to match the canonical style of "<subsystem>: " for patch headers.
Don't worry about resending, I can fix this up, but it would be nice not to have to worry about it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |