lkml.org 
[lkml]   [2007]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 2.6.21-rc3-mm2 (BUG in pci_restore_state())
Date
Bjorn Helgaas <bjorn.helgaas@hp.com> writes:

> In 2.6.21-rc3-mm2 (plus some move_freepages() bugfixes), I hit one
> of the warnings added by Eric's msi-debug-code.patch. This is on an
> ia64 box, an HP rx2600. Let me know if I can collect more information.

I think we are good. How pci_save_state and pci_restore_state were
implemented and how they were used were out of sync. tg3 was one
of the drivers where pci_save_state and pci_restore_state were used
as part of the reset routine and were not used in pairs.

Which when combined with a pci-x or a pci-express capability
resulted in a memory leak, (that I was warning about). This
has now been corrected upstream.

And the condition I was warning about non paired pci_save_state and
pci_restore_state is no longer a problem.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-15 02:17    [W:0.227 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site