Messages in this thread | | | Date | Fri, 9 Feb 2007 22:52:55 +0000 | From | Pavel Machek <> | Subject | Re: [PATCH] Add PM_TRACE x86_64 support. |
| |
Hi!
> > > Nigel Cunningham <nigel@nigel.suspend2.net> writes: > > > > > > > - for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; tracedata += 6) { > > > > + for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; tracedata += 2 + sizeof(unsigned long)) { > > > > > > Could you split this line? > > > > Sure. > > > > -- New version -- (What's the right way to do this?) > > > > This patch add x86_64 support for PM_TRACE, and shifts per-arch code to > > the appropriate subdirectories. > > > > Symbol exports are added so tracing can be used from drivers built as > > modules too. > > Don't include exports in a patch that doesn't use them. Introduce the > exports in a later patch series, for when you actually need it.
It is debugging infrastructure, so export actually makes sense... It will not ever be used in mainline kernel; you need to modify code manually to use this code..
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |