![]() | |||||||||||
Messages in this thread |
On Thu, Feb 08 2007, Nigel Cunningham wrote:
> On Wed, 2007-02-07 at 23:18 -0200, Otavio Salvador wrote:
> > Nigel Cunningham <nigel@nigel.suspend2.net> writes:
> >
> > > - for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; tracedata += 6) {
> > > + for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; tracedata += 2 + sizeof(unsigned long)) {
> >
> > Could you split this line?> > Sure.> > -- New version -- (What's the right way to do this?)
> > This patch add x86_64 support for PM_TRACE, and shifts per-arch code to
> the appropriate subdirectories.> > Symbol exports are added so tracing can be used from drivers built as
> modules too.
Don't include exports in a patch that doesn't use them. Introduce the
exports in a later patch series, for when you actually need it.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| ||||||||||
| Last update: 2007-02-08 13:41 [from the cache] ©2003-2008 | |||||||||||