Messages in this thread Patch in this message | | | Date | Tue, 11 Dec 2007 15:42:22 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action. |
| |
Perhaps we should change the warning to identify the guilty device.
--- a/net/core/dev.c 2007-11-19 09:09:57.000000000 -0800 +++ b/net/core/dev.c 2007-12-07 15:54:03.000000000 -0800 @@ -2196,7 +2196,13 @@ static void net_rx_action(struct softirq if (test_bit(NAPI_STATE_SCHED, &n->state)) work = n->poll(n, weight); - WARN_ON_ONCE(work > weight); + if (unlikely(work > weight)) { + if (net_ratelimit()) + printk(KERN_WARNING + "%s: driver poll bug (work=%d weight=%d)\n", + work, weight); + work = weight; + } budget -= work;
| |