Messages in this thread | | | Subject | RE: [PATCH] [NET]: Fix Ooops of napi net_rx_action. | Date | Tue, 11 Dec 2007 15:12:10 -0800 | From | "Brandeburg, Jesse" <> |
| |
Joonwoo Park wrote: > /* If no Tx and not enough Rx work done, exit the polling mode */ > if ((!tx_cleaned && (work_done == 0)) || > !netif_running(poll_dev)) { > quit_polling: > if (likely(adapter->itr_setting & 3)) > e1000_set_itr(adapter); > netif_rx_complete(poll_dev, napi); > e1000_irq_enable(adapter);
all drivers using NAPI in 2.6.24+ (NNAPI??) must return zero here, after calling netif_rx_complete. netif_rx_complete plus work_done != 0 causes a bug.
> } > > return work_done; > } >
| |