lkml.org 
[lkml]   [2006]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/22][RFC] Unionfs: Lookup helper functions

>+ if ((bopaque != -1) && (bopaque < bend))

>+ /* If we've only got negative dentries, then use the leftmost one. */
>+ if (lookupmode == INTERPOSE_REVAL) {
>+ if (dentry->d_inode) {
>+ itopd(dentry->d_inode)->uii_stale = 1;
>+ }
>+ goto out;
>+ }
>+ if (!newsize || ((oldsize < newsize) && (newsize > minsize))) {

Some places where -() and -{}

>+static int is_opaque_dir(struct dentry *dentry, int bindex)
>+{
>+ int err = 0;
>+ /* This is an opaque dir iff wh_hidden_dentry is positive */
>+ err = !!wh_hidden_dentry->d_inode;
>+out:
>+ return err;
>+}

This smells like a bool function. If so, don't call it "err" (since boolean
functions do not return "errors").



Jan Engelhardt
--

--
VGER BF report: H 8.44923e-11
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-04 09:31    [W:0.732 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site