lkml.org 
[lkml]   [2006]   [Sep]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 04 Sep 2006 00:23:14 -0700
FromJeremy Fitzhardinge <>
SubjectRe: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions
Jan Engelhardt wrote:
>> +	if (0 <= bopaque && bopaque < bend)
>> 
>
> Turn it. Constant values are usually wanted on the right side.
>
> 	bopaque >= 0

Not in this case.  The test in its current form clearly shows that 
bopaque needs to be within a range.


    J

-- 
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-04 09:25    [from the cache]
©2003-2008