Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18 | Date | Thu, 28 Sep 2006 14:35:01 +0200 |
| |
On Thursday 28 September 2006 13:39, Bernd Schmidt wrote: > > > Shouldn't you just use a constant expression here? A global variable > > for it sounds rather strange, especially since the local_irq_disable() > > calls are sometimes nested, not to mention the problems you'd hit on > > SMP? > > It's not a constant - there are some {un,}mask_irq functions that may > change it. We don't have SMP, obviously it would have to be per-CPU if > we did. > Ok, got it now. I did not realize that you use the same register for global irq enable and for specific interrupts that can be masked.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |