Messages in this thread | | | Date | Thu, 28 Sep 2006 13:39:08 +0200 | From | Bernd Schmidt <> | Subject | Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18 |
| |
Arnd Bergmann wrote: >> We want to restore the proper >> mask of enabled interrupts with the STI. That mask is in the global >> irq_flags variable (which probably ought to have a different name that >> doesn't invite clashes). > > Shouldn't you just use a constant expression here? A global variable > for it sounds rather strange, especially since the local_irq_disable() > calls are sometimes nested, not to mention the problems you'd hit on > SMP?
It's not a constant - there are some {un,}mask_irq functions that may change it. We don't have SMP, obviously it would have to be per-CPU if we did.
Bernd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |