Messages in this thread | | | Date | Sun, 6 Aug 2006 13:05:20 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: single bit flip detector. |
| |
On Wed, 2 Aug 2006, Jan Engelhardt wrote: > > printk(" %02x", (unsigned char)data[offset + i]); > > Remove cast. (Or does it spew a warning message for you?)
No warning, but you still want the cast...
On PPC and ARM that will work fine, since char is unsigned.
But on most other platforms char is signed, and contrary to popular belief, `%02x' doesn't mean `limit this field to 2 characters', so it would print e.g. ffffffff instead of ff for -1.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |