Messages in this thread | | | Date | Fri, 4 Aug 2006 18:06:44 -0400 | From | Dave Jones <> | Subject | Re: single bit flip detector. |
| |
On Fri, Aug 04, 2006 at 02:19:55PM -0700, Andrew Morton wrote: > On Tue, 1 Aug 2006 20:16:26 -0400 > Dave Jones <davej@redhat.com> wrote: > > > In case where we detect a single bit has been flipped, we spew > > the usual slab corruption message, which users instantly think > > is a kernel bug. In a lot of cases, single bit errors are > > down to bad memory, or other hardware failure. > > > > This patch adds an extra line to the slab debug messages > > in those cases, in the hope that users will try memtest before > > they report a bug. > > Well boy, this has to be the most-reviewed patch ever. You'd think that > I'd apply it with great confidence and warm fuzzies.
I should stick to one-liner fixes.
> - one decl per line is more patching-friendly and a bit more idiomatic. > - make `bad_count' an int: a uchar might overflow > - Put a blank line between decls and code > - rename `total' to `error', remove `errors'. > - there's no need to sum up the errors. > - don't need to check for non-zero `errors': we know it is != POISON_FREE. > - make it look non-crapful in an 80-col window. > - add missing spaces in arithmetic
With this much iteration, I do have one question.. Does it still work ? :-)
Dave
-- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |