Messages in this thread | | | Subject | Re: [Patch] Signedness issue in drivers/net/3c515.c | From | Alan Cox <> | Date | Mon, 21 Aug 2006 23:13:25 +0100 |
| |
Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton: > /* Wait for the stall to complete. */ > for (i = 20; i >= 0; i--) > if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0) > break; > > Your fix will convert this indefinit wait into a bounded one. It might > cause the driver to malfunction.
The change is correct. The docs guarantee it can't take that long.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |