lkml.org 
[lkml]   [2006]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Patch] Signedness issue in drivers/net/3c515.c
From
Date
Ar Sad, 2006-08-19 am 19:37 +0200, ysgrifennodd Eric Sesterhenn:
> hi,
>
> while playing with gcc 4.1 -Wextra warnings, I came across this one:
>
> drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true
>
> Since i is unsigned the >= 0 check in the for loop is always true,
> so we might spin there forever unless the if condition triggers.
> Since i is only used in this loop, this patch changes it to
> an integer.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>

Acked-by: Alan Cox <alan@redhat.com>

[And put JG on the Cc:]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-20 20:05    [W:0.045 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site