lkml.org 
[lkml]   [2006]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] memory hotadd fixes [4/5] avoid check in acpi

    add_memory() does all necessary check to avoid collision.
    then, acpi layer doesn't have to check region by itself.

    (*) pfn_valid() just returns page struct is valid or not. It returns 0
    if a section has been already added even is ioresource is not added.
    ioresource collision check in mm/memory_hotplug.c can do more precise
    collistion check.
    added enabled bit check just for sanity check..

    Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>


    drivers/acpi/acpi_memhotplug.c | 9 +--------
    1 files changed, 1 insertion(+), 8 deletions(-)

    Index: linux-2.6.18-rc3/drivers/acpi/acpi_memhotplug.c
    ===================================================================
    --- linux-2.6.18-rc3.orig/drivers/acpi/acpi_memhotplug.c 2006-08-01 16:11:47.000000000 +0900
    +++ linux-2.6.18-rc3/drivers/acpi/acpi_memhotplug.c 2006-08-02 14:12:45.000000000 +0900
    @@ -230,17 +230,10 @@
    * (i.e. memory-hot-remove function)
    */
    list_for_each_entry(info, &mem_device->res_list, list) {
    - u64 start_pfn, end_pfn;
    -
    - start_pfn = info->start_addr >> PAGE_SHIFT;
    - end_pfn = (info->start_addr + info->length - 1) >> PAGE_SHIFT;
    -
    - if (pfn_valid(start_pfn) || pfn_valid(end_pfn)) {
    - /* already enabled. try next area */
    + if (info->enabled) { /* just sanity check...*/
    num_enabled++;
    continue;
    }
    -
    result = add_memory(node, info->start_addr, info->length);
    if (result)
    continue;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-03 05:37    [W:0.023 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site