Messages in this thread | | | Date | Thu, 10 Aug 2006 16:17:35 -0400 | From | Jeff Mahoney <> | Subject | Re: [PATCH 2/9] sector_t format string |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Alexey Dobriyan wrote: > On Thu, Aug 10, 2006 at 12:17:47PM -0700, Joel Becker wrote: >> On Wed, Aug 09, 2006 at 11:40:19PM -0700, Andrew Morton wrote: >>> On Wed, 09 Aug 2006 18:20:43 -0700 >>> Mingming Cao <cmm@us.ibm.com> wrote: >>> >>>> Define SECTOR_FMT to print sector_t in proper format >>> We've thus-far avoided doing this. In fact a similar construct in >>> device-mapper was recently removed. >> Yeah, OCFS2 had similar formats, and we were asked to change >> them to naked casts before inclusion. Seems quite consistent with the >> rest of the kernel. > > Will > > printk("%S", sector_t); > > kill at least one kitten?
I like the general idea. I think that having to cast every time you want to print a sector number is pretty gross. I had something more like %Su in mind, though.
- -Jeff
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFE25RfLPWxlyuTD7IRAshdAJ0dboV4trG1Pgy6P+sqPiV0bWabYQCgiZng FuaanX+K+jSTwlrapumR1XY= =jLoe -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |