Messages in this thread Patch in this message | | | Subject | [PATCH] fix synclink_gt diagnostics error reporting | From | Paul Fulghum <> | Date | Wed, 21 Jun 2006 09:33:09 -0500 |
| |
Fix diagnostics error reporting that was being overwritten by incorrect use of return codes from individual diagnostic functions.
Signed-off-by: Paul Fulghum <paulkf@microgate.com>
--- a/drivers/char/synclink_gt.c 2006-06-21 09:04:11.000000000 -0500 +++ b/drivers/char/synclink_gt.c 2006-06-21 09:24:51.000000000 -0500 @@ -4671,13 +4671,13 @@ static int loopback_test(struct slgt_inf static int adapter_test(struct slgt_info *info) { DBGINFO(("testing %s\n", info->device_name)); - if ((info->init_error = register_test(info)) < 0) { + if (register_test(info) < 0) { printk("register test failure %s addr=%08X\n", info->device_name, info->phys_reg_addr); - } else if ((info->init_error = irq_test(info)) < 0) { + } else if (irq_test(info) < 0) { printk("IRQ test failure %s IRQ=%d\n", info->device_name, info->irq_level); - } else if ((info->init_error = loopback_test(info)) < 0) { + } else if (loopback_test(info) < 0) { printk("loopback test failure %s\n", info->device_name); } return info->init_error;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |