lkml.org 
[lkml]   [2006]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver
HighPoint Linux Team wrote:
> --- a/drivers/scsi/hptiop.c
> +++ b/drivers/scsi/hptiop.c
> @@ -504,18 +504,10 @@ static int hptiop_queuecommand(struct sc
> BUG_ON(!done);
> scp->scsi_done = done;
>
> - /*
> - * hptiop_shutdown will flash controller cache.
> - */
> - if (scp->cmnd[0] == SYNCHRONIZE_CACHE) {
> - scp->result = DID_OK<<16;
> - goto cmd_done;
> - }
> -
> _req = get_req(hba);
> if (_req == NULL) {
> dprintk("hptiop_queuecmd : no free req\n");
> - scp->result = DID_BUS_BUSY << 16;
> + scp->result = SCSI_MLQUEUE_HOST_BUSY;
> goto cmd_done;
> }

Close. For the last bit of code quoted above, you should return
SCSI_MLQUEUE_HOST_BUSY as your ->queuecommand() return code, rather than
setting scp->result and calling the done() hook.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-11 15:17    [W:0.076 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site