Messages in this thread | | | Date | Sun, 11 Jun 2006 09:14:26 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver |
| |
HighPoint Linux Team wrote: > --- a/drivers/scsi/hptiop.c > +++ b/drivers/scsi/hptiop.c > @@ -504,18 +504,10 @@ static int hptiop_queuecommand(struct sc > BUG_ON(!done); > scp->scsi_done = done; > > - /* > - * hptiop_shutdown will flash controller cache. > - */ > - if (scp->cmnd[0] == SYNCHRONIZE_CACHE) { > - scp->result = DID_OK<<16; > - goto cmd_done; > - } > - > _req = get_req(hba); > if (_req == NULL) { > dprintk("hptiop_queuecmd : no free req\n"); > - scp->result = DID_BUS_BUSY << 16; > + scp->result = SCSI_MLQUEUE_HOST_BUSY; > goto cmd_done; > }
Close. For the last bit of code quoted above, you should return SCSI_MLQUEUE_HOST_BUSY as your ->queuecommand() return code, rather than setting scp->result and calling the done() hook.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |