lkml.org 
[lkml]   [2006]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 29/35] Add the Xen virtual console driver.
Andrew Morton wrote:

>>+static void kcons_write_dom0(
>>+ struct console *c, const char *s, unsigned int count)
>>+{
>>+ int rc;
>>+
>>+ while ((count > 0) &&
>>+ ((rc = HYPERVISOR_console_io(
>>+ CONSOLEIO_write, count, (char *)s)) > 0)) {
>>+ count -= rc;
>>+ s += rc;
>>+ }
>>+}
>
>
> must.. not.. mention.. coding.. style..

Someone should write you a script to go through a patch and flag the
most common style mistakes. Have the output formatted to look like
you're replying to the mail, and wire it up to your inbox ;)

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-13 14:55    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site