lkml.org 
[lkml]   [2006]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC PATCH 29/35] Add the Xen virtual console driver.
    Date

    > --- linus-2.6.orig/drivers/char/tty_io.c
    > +++ linus-2.6/drivers/char/tty_io.c
    > @@ -132,6 +132,8 @@ LIST_HEAD(tty_drivers); /* linked list
    > vt.c for deeply disgusting hack reasons */
    > DEFINE_MUTEX(tty_mutex);
    >
    > +int console_use_vt = 1;
    > +

    Can you explain why this variable is needed? It shouldn't. If you only
    register your console as the primary console nothing else should
    be printed.


    > +/*** Useful function for console debugging -- goes straight to Xen. ***/
    > +asmlinkage int xprintk(const char *fmt, ...)

    This is called early_printk in the rest of i386. Please use that name too.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-09 15:29    [W:0.019 / U:0.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site