Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH] Shrink rbtree | Date | Sun, 23 Apr 2006 00:55:55 +0200 |
| |
Hio David,
On Saturday, 22. April 2006 15:38, David Woodhouse wrote: > I'm reluctant to 'bless' this practice, because we'll then get asked to > set it to 'inactive' every time we take a node off the tree, to have a > BUG_ON() which checks it in certain places, etc.... it's mostly > pointless AFAICT.
I understand your point. Can we agree on just doing this for functions which are handed off-tree and on-tree nodes and have to care for locking reasons?
It is ok for functions to enforce their API with BUG_ON(). But this part should not be generalized, since this part really depends on the user.
Each rbtree user having its own private hackery for this is wasted developer resources IMHO.
So please either provide common helpers or just delete the potential users if you think this is not needed.
I'm happy either way.
Regards
Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |