Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH] Shrink rbtree | Date | Sat, 22 Apr 2006 14:29:26 +0200 |
| |
Hi David,
On Saturday, 22. April 2006 03:29, David Woodhouse wrote: > On Fri, 2006-04-21 at 18:09 -0700, Andrew Morton wrote: > > #define HRTIMER_INACTIVE ((void *)1UL) > > Ah. That's newer than the kernel I tested on. Your patch isn't going to > make kernel/hrtimer.c compile though, surely? Let's do it the same way > everyone else marks off-tree nodes -- by setting its parent pointer to > point to itself....
Yes, but please make it a common helper, since there is a real need for it and code has to agree on the dirty hacks it uses :-)
static inline int rb_in_tree(const struct rb_node *node) { return rb_parent(node) != node; }
static inline void rb_set_off_tree(struct rb_node *node) { rb_set_parent(node, node); }
This is trivial, but gives semantics to those strange operations.
Regards
Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |