Messages in this thread | | | Date | Tue, 21 Mar 2006 16:26:30 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] hpet header sanitization |
| |
On Tue, 21 Mar 2006 16:13:03 -0800 Andrew Morton wrote:
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote: > > > > From: Randy Dunlap <rdunlap@xenotime.net> > > > > Add __KERNEL__ block. > > Use __KERNEL__ to allow ioctl interface to be usable. > > hm, why?
because there is a test/example source file in (inside) Documentation/hpet.txt that won't build otherwise. And because hpet.h contains _userspace_ ioctl interface struct and macros...
> My general approach to __KERNEL__ fixes is to not support new includers of > kernel headers but to accept patches which fix up existing applications of > __KERNEL__. > > It's basically a compromise between the > dont-include-kernel-headers-from-userspace fundamentalists and the > but-i-want-my-stuff-to-work pragmatists ;) > > But hpet.h never had __KERNEL__, so there's no regression here. > > That being said, it looks like a sensible change - let's see if we can > sneak it in without the fundies noticing.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |