Messages in this thread |  | | | Date | Wed, 22 Mar 2006 09:01:25 -0800 | | From | "Randy.Dunlap" <> | | Subject | Re: [PATCH] hpet header sanitization |
| |
On Wed, 22 Mar 2006 12:14:46 +0100 Clemens Ladisch wrote:
> Arnd Bergmann wrote: > > On Tuesday 21 March 2006 23:46, Randy.Dunlap wrote: > > > +#define HPET_IE_ON _IO('h', 0x01) /* interrupt on */ > > > +#define HPET_IE_OFF _IO('h', 0x02) /* interrupt off */ > > > +#define HPET_INFO _IOR('h', 0x03, struct hpet_info) > > > +#define HPET_EPI _IO('h', 0x04) /* enable periodic */ > > > +#define HPET_DPI _IO('h', 0x05) /* disable periodic */ > > > +#define HPET_IRQFREQ _IOW('h', 0x6, unsigned long) /* IRQFREQ usec */ > > > > By the way, HPET_INFO and HPET_IRQFREQ don't work for 32 bit user space, > > the driver needs a compat_ioctl() method to handle those. > > There isn't any program (except the example in the docs) that uses any > of these ioctls, and I'm writing patches to make this device available > through portable timer APIs like hrtimer/POSIX clocks/ALSA that are much > easier to use besides, so I think it would be a good idea to just > schedule these ioctls for removal.
How do you (or can you) know that there are no programs that use that ioctl? Yes, scheduling for removal would be OK.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |