Messages in this thread | | | Date | Thu, 02 Feb 2006 17:01:27 -0800 (PST) | Subject | Re: [lock validator] inet6_destroy_sock(): soft-safe -> soft-unsafe lock dependency | From | "David S. Miller" <> |
| |
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Wed, 1 Feb 2006 21:42:14 +1100
> OK this is definitely broken. We should never touch the dst lock in > softirq context. Since inet6_destroy_sock may be called from that > context due to the asynchronous nature of sockets, we can't take the > lock there. > > In fact this sk_dst_reset is totally redundant since all IPv6 sockets > use inet_sock_destruct as their socket destructor which always cleans > up the dst anyway. So the solution is to simply remove the call. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Looks good, applied, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |