Messages in this thread Patch in this message | | | Subject | [patch] fuse: remove clear_page_dirty() call | From | Miklos Szeredi <> | Date | Thu, 21 Dec 2006 15:18:23 +0100 |
| |
> And with that, I then either rip out any old users of > "test_clear_page_dirty()" or "clear_page_dirty()", and if appropriate (and > it's realy lonly appropriate for "truncate()", I replace them with the new > "cancel_dirty_page()". Most of the time, they should just be deleted > entirely. > > NOTE NOTE NOTE! I _only_ did enough to make things compile for my > particular configuration. That means that right now the following > filesystems are broken with this patch (because they use the totally > broken old crap): > > CIFS, FUSE, JFS, ReiserFS, XFS
The use by FUSE was just a remnant of an optimization from the time when writable mappings were supported.
Now FUSE never actually allows the creation of dirty pages, so this invocation of clear_page_dirty() is effectively a no-op.
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> ---
Index: linux/fs/fuse/file.c =================================================================== --- linux.orig/fs/fuse/file.c 2006-12-21 15:06:32.000000000 +0100 +++ linux/fs/fuse/file.c 2006-12-21 15:07:02.000000000 +0100 @@ -483,10 +483,8 @@ static int fuse_commit_write(struct file i_size_write(inode, pos); spin_unlock(&fc->lock); - if (offset == 0 && to == PAGE_CACHE_SIZE) { - clear_page_dirty(page); + if (offset == 0 && to == PAGE_CACHE_SIZE) SetPageUptodate(page); - } } fuse_invalidate_attr(inode); return err; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |