Messages in this thread Patch in this message | | | Date | Mon, 27 Nov 2006 14:02:54 +0900 | From | Akinobu Mita <> | Subject | [PATCH] iscsi: fix crypto_alloc_hash() error check |
| |
The return value of crypto_alloc_hash() should be checked by IS_ERR().
Cc: Dmitry Yusupov <dmitry_yus@yahoo.com> Cc: Alex Aizman <itn780@yahoo.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
--- drivers/scsi/iscsi_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Index: work-fault-inject/drivers/scsi/iscsi_tcp.c =================================================================== --- work-fault-inject.orig/drivers/scsi/iscsi_tcp.c +++ work-fault-inject/drivers/scsi/iscsi_tcp.c @@ -1777,13 +1777,13 @@ iscsi_tcp_conn_create(struct iscsi_cls_s tcp_conn->tx_hash.tfm = crypto_alloc_hash("crc32c", 0, CRYPTO_ALG_ASYNC); tcp_conn->tx_hash.flags = 0; - if (!tcp_conn->tx_hash.tfm) + if (IS_ERR(tcp_conn->tx_hash.tfm)) goto free_tcp_conn; tcp_conn->rx_hash.tfm = crypto_alloc_hash("crc32c", 0, CRYPTO_ALG_ASYNC); tcp_conn->rx_hash.flags = 0; - if (!tcp_conn->rx_hash.tfm) + if (IS_ERR(tcp_conn->rx_hash.tfm)) goto free_tx_tfm; return cls_conn; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |