lkml.org 
[lkml]   [2006]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched.c : correct comment for this_rq_lock() routine
Robert P. J. Day wrote:

>example, i was just poking around the source for the various
>"atomic.h" files and noticed a couple possible cleanups:
>
> 1) make sure *everyone* uses "volatile" in the typedef struct (which
> i actually submitted recently)
>

I don't see why. There is nothing in atomic (eg. atomic_read) that says
there must be a compiler barrier around the operation.

Have you checked that the architecture implementation actually needs the
volatile where you've added it?

--

Send instant messages to your online friends http://au.messenger.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-31 23:49    [W:0.369 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site