Messages in this thread Patch in this message | | | Date | Fri, 13 Oct 2006 10:57:41 +0300 (EEST) | From | Pekka J Enberg <> | Subject | [PATCH] ecryptfs: use special_file |
| |
From: Pekka Enberg <penberg@cs.helsinki.fi>
Use the special_file() macro to check whether an inode is special instead of open-coding it.
Cc: Mike Halcrow <mhalcrow@us.ibm.com> Cc: Phillip Hellewell <phillip@hellewell.homeip.net> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> ---
fs/ecryptfs/main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Index: 2.6/fs/ecryptfs/main.c =================================================================== --- 2.6.orig/fs/ecryptfs/main.c +++ 2.6/fs/ecryptfs/main.c @@ -104,10 +104,7 @@ int ecryptfs_interpose(struct dentry *lo inode->i_op = &ecryptfs_dir_iops; if (S_ISDIR(lower_inode->i_mode)) inode->i_fop = &ecryptfs_dir_fops; - /* TODO: Is there a better way to identify if the inode is - * special? */ - if (S_ISBLK(lower_inode->i_mode) || S_ISCHR(lower_inode->i_mode) || - S_ISFIFO(lower_inode->i_mode) || S_ISSOCK(lower_inode->i_mode)) + if (special_file(lower_inode->i_mode)) init_special_inode(inode, lower_inode->i_mode, lower_inode->i_rdev); dentry->d_op = &ecryptfs_dops; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |