Messages in this thread Patch in this message | | | From | Ed L Cashin <> | Subject | Re: aoe fails on sparc64 | Date | Fri, 16 Sep 2005 09:36:51 -0400 |
| |
Jim MacBaine <jmacbaine@gmail.com> writes:
> Hello, > > Using aoe on a sparc64 system gives strange results: > > sunny:/dev/etherd# echo >discover > sunny:/dev/etherd# mke2fs e0.0 > mke2fs 1.37 (21-Mar-2005) > mke2fs: File too large while trying to determine filesystem size > sunny:/dev/etherd# blockdev --getsz e0.0 > -4503599627370496 > > The log says: > > Aug 31 15:18:49 sunny kernel: devfs_mk_dir: invalid argument.<6> > etherd/e0.0: unknown partition table > Aug 31 15:18:49 sunny kernel: aoe: 0011d8xxxxxx e0.0 v4000 has > 67553994410557440 > sectors > > The system is an Sun Ultra 5, running 2.6.12.5/sparc64 compiled with > gcc-3.4.2. e0.0 is exported on a x86 system using vblade-5, and has a > size of 30 MB.
I've been working with Jim MacBaine, and he reports that the patch below gets rid of the problem. I don't know why. When I test le64_to_cpup by itself, it works as expected.
Index: linux-2.6.13/drivers/block/aoe/aoecmd.c =================================================================== --- linux-2.6.13.orig/drivers/block/aoe/aoecmd.c 2005-08-31 17:03:52.000000000 -0400 +++ linux-2.6.13/drivers/block/aoe/aoecmd.c 2005-09-15 15:44:41.000000000 -0400 @@ -320,7 +320,8 @@ d->flags |= DEVFL_EXT; /* word 100: number lba48 sectors */ - ssize = le64_to_cpup((__le64 *) &id[100<<1]); + ssize = *((u64 *) &id[100<<1]); + ssize = le64_to_cpu(ssize); /* set as in ide-disk.c:init_idedisk_capacity */ d->geo.cylinders = ssize;
-- Ed L Cashin <ecashin@coraid.com>
| |