lkml.org 
[lkml]   [2005]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error handling/detecting
    From
    In article <42CB63B2.6000505@jp.fujitsu.com> (at Wed, 06 Jul 2005 13:53:06 +0900), Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> says:

    > Index: linux-2.6.13-rc1/lib/iomap.c
    > ===================================================================
    > --- linux-2.6.13-rc1.orig/lib/iomap.c
    > +++ linux-2.6.13-rc1/lib/iomap.c
    > @@ -230,3 +230,9 @@ void pci_iounmap(struct pci_dev *dev, vo
    > }
    > EXPORT_SYMBOL(pci_iomap);
    > EXPORT_SYMBOL(pci_iounmap);
    > +
    > +#ifndef HAVE_ARCH_IOMAP_CHECK
    > +/* Since generic funcs are inlined and defined in header, just export */
    > +EXPORT_SYMBOL(iochk_clear);
    > +EXPORT_SYMBOL(iochk_read);
    > +#endif
    > Index: linux-2.6.13-rc1/include/asm-generic/iomap.h
    > ===================================================================
    > --- linux-2.6.13-rc1.orig/include/asm-generic/iomap.h
    > +++ linux-2.6.13-rc1/include/asm-generic/iomap.h
    :
    > + */
    > +#ifdef HAVE_ARCH_IOMAP_CHECK
    > +extern void iochk_init(void);
    > +extern void iochk_clear(iocookie *cookie, struct pci_dev *dev);
    > +extern int iochk_read(iocookie *cookie);
    > +#else
    > +static inline void iochk_init(void) {}
    > +static inline void iochk_clear(iocookie *cookie, struct pci_dev *dev) {}
    > +static inline int iochk_read(iocookie *cookie) { return 0; }
    > +#endif
    > +
    > #endif

    It looks strange to me.
    You cannot export "static inline" functions.
    You can export iochk_{init,clear,read} only
    if HAVE_ARCH_IOMAP_CHECK is defined.

    --yoshfuji
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-06 09:58    [W:0.023 / U:33.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site