lkml.org 
[lkml]   [2005]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.13-rc1 03/10] IOCHK interface for I/O error handling/detecting
    Linas Vepstas wrote:
    > Thus, one wouldn't want to perform an iochk_read() in this way unless
    > one was already pretty sure that an error had already occured ...

    If another kind of I/O error detecting system finds a error before
    performing iochk_read(), it can prevents coming iochk_read() from
    spending such crazy cycles in have_error() by marking cookie->error.

    >> int iochk_read(iocookie *cookie)
    >> {
    >> + if (cookie->error || have_error(cookie->dev))

    Isn't it enough?

    And as Ben said, it seems that ppc64 can have its own special iochk_*,
    unless calling pci_read_config_word() ;-)

    Thanks,
    H.Seto

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-13 03:35    [W:0.020 / U:124.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site