Messages in this thread | | | Subject | Re: Page Fault Scalability patch V19 [4/4]: Drop use of page_table_lock in do_anonymous_page | From | Andi Kleen <> | Date | Wed, 09 Mar 2005 23:56:14 +0100 |
| |
Christoph Lameter <clameter@sgi.com> writes:
> Do not use the page_table_lock in do_anonymous_page. This will significantly > increase the parallelism in the page fault handler in SMP systems. The patch > also modifies the definitions of _mm_counter functions so that rss and anon_rss > become atomic.
I still think it's a bad idea to add arbitary process size limits like this:
> > +#ifdef CONFIG_ATOMIC_TABLE_OPS > +/* > + * Atomic page table operations require that the counters are also > + * incremented atomically > +*/ > +#define set_mm_counter(mm, member, value) atomic_set(&(mm)->member, value) > +#define get_mm_counter(mm, member) ((unsigned long)atomic_read(&(mm)->member)) > +#define update_mm_counter(mm, member, value) atomic_add(value, &(mm)->member) > +#define MM_COUNTER_T atomic_t
Can you use atomic64_t on 64bit systems at least?
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |