Messages in this thread | | | Date | Mon, 21 Mar 2005 16:53:10 +0300 | From | Ivan Kokshaysky <> | Subject | Re: [PATCH] alpha build fixes |
| |
On Mon, Mar 21, 2005 at 11:27:39PM +1100, Benjamin Herrenschmidt wrote: > IRQs on IDE in legacy mode is sort of an out-of-spec piece of junk that > was invented to make PCI based peecees "look like" good old rotten > hardware, unfortunately, some modern and non-x86 HW vendors still don't > haev a clue and configure (wire in some case) their on board IDE in > legacy mode, but with IRQs that, on those archs, aren't 14 and 15. That > hook fixes the problem on some ppc64 machines but should be extended to > cover various other cases where similar shit happens.
Indeed, such setup is quite typical for southbridge chips with integrated IDE controller - they still simulate sort of ISA IRQ routing...
> It's in PCI because I figured it was as bad there than anywhere else. In > this case, it's the IDE layer asking the PCI layer "hey, that guy > doesn't respect the normal PCI IRQ mapping, can you tell me how it's > routed ?" :) Back then, I didn't know of a header shared between ide and > libata so I put it there.
Ok, but asm-generic/pci.h is not a good place for default IRQ 14/15 case - this header cannot be included on non-x86 without additional #ifdef's. Perhaps we can move it to linux/pci.h or linux/ata.h (as Bart noted)?
Ivan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |