Messages in this thread | | | Date | Mon, 21 Mar 2005 10:45:40 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] alpha build fixes |
| |
On Mon, 21 Mar 2005 12:16:16 +0300, Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote: > On Mon, Mar 21, 2005 at 09:05:39AM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Sat, 19 Mar 2005 18:16:41 -0500, Jeff Garzik <jgarzik@pobox.com> wrote: > > > On Sat, Mar 19, 2005 at 03:11:16PM -0800, Richard Henderson wrote: > > > > On Fri, Mar 18, 2005 at 11:34:07PM -0500, Jeff Garzik wrote: > > > > > +/* TODO: integrate with include/asm-generic/pci.h ? */ > > > > > +static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) > > > > > +{ > > > > > + return channel ? 15 : 14; > > > > > +} > > > > > > > > Am I missing something, or is this *only* used by drivers/ide/pci/amd74xx.c? > > > > Why in the world would we have this much infrastructure for one driver? And > > > > why not just not compile that one for Alpha, since it'll never be used. > > > > > > My presumption is that it will be used in other IDE drivers in the > > > future. Bart? > > > > This code is meant to be used by other IDE/libata drivers. > > Then isn't linux/ide.h the proper place for default pci_get_legacy_ide_irq()
ide.h is not shared between IDE and libata drivers (but ata.h is)
> implementation instead of asm-generic/pci.h? The latter is only used by > 7 out of 23 architectures, so not only alpha gets broken.
I'm cc:ing Ben as it was his idea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |