Messages in this thread | | | Date | Sun, 6 Feb 2005 19:28:45 +0100 | From | Olaf Hering <> | Subject | Re: [PATCH] Bug in tty_io.c after changes between 2.6.9-rc1-bk1 and 2.6.9-rc1-bk2 |
| |
On Thu, Feb 03, Linux Kernel Mailing List wrote:
> ChangeSet 1.1992.2.73, 2005/02/02 08:48:23-08:00, pavenis@latnet.lv > > [PATCH] Bug in tty_io.c after changes between 2.6.9-rc1-bk1 and 2.6.9-rc1-bk2 > > Fix http://bugzilla.kernel.org/show_bug.cgi?id=3736 > > Finally located that a problem seems to be a simple typo. > > Acked-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk> > Signed-off-by: Andrew Morton <akpm@osdl.org> > Signed-off-by: Linus Torvalds <torvalds@osdl.org> > > > > tty_io.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff -Nru a/drivers/char/tty_io.c b/drivers/char/tty_io.c > --- a/drivers/char/tty_io.c 2005-02-02 10:45:08 -08:00 > +++ b/drivers/char/tty_io.c 2005-02-02 10:45:08 -08:00 > @@ -1156,8 +1156,8 @@ > int i = index + driver->name_base; > /* ->name is initialized to "ttyp", but "tty" is expected */ > sprintf(p, "%s%c%x", > - driver->subtype == PTY_TYPE_SLAVE ? "tty" : driver->name, > - ptychar[i >> 4 & 0xf], i & 0xf); > + driver->subtype == PTY_TYPE_SLAVE ? "pty" : driver->name, > + ptychar[i >> 4 & 0xf], i & 0xf); > }
This change looks very bogus, what are you trying to fix here?
if pty_driver->subtype == PTY_TYPE_MASTER, a node ptyXY has to be created. if pty_driver->subtype == PTY_TYPE_SLAVE, a node ttyXY has to be created. See Documentation/devices.txt, line 108ff and 183ff
With your change, the ttyXY becomes ptyXY? Why does that fix anything?
Do you have an outdated udev package with bogus udev.rules? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |