Messages in this thread | | | Date | Mon, 28 Feb 2005 16:16:15 +0100 | From | colbuse@ensisun ... | Subject | Re: [patch 2/2] drivers/chat/vt.c: remove unnecessary code |
| |
>On Mon, Feb 28, 2005 at 01:55:28PM +0100, colbuse@xxxxxxxxxxxxxxx wrote: > >> Avoid changing the state of the console two times in some cases. > >A bad change for several reasons. > >(i) more object code is generated >(ii) the code is slower >(iii) you change something > >Straight line code is cheap, jumps are expensive. >Replacing an assignment by a jump is not an improvement.
I didn't thought to that point...
You're right, this patch was a bad idea :(.
Sorry about this error...
-- Emmanuel Colbus Club GNU/Linux ENSIMAG - Departement telecoms
------------------------------------------------- envoyé via Webmail/IMAG !
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |