Messages in this thread | | | Date | Tue, 15 Feb 2005 15:29:39 -0800 | From | Mitchell Blank Jr <> | Subject | Re: [PATCH] ext3: Fix sparse -Wbitwise warnings. |
| |
Stephen C. Tweedie wrote: > If we want to fix this, let's fix the macros: for example, convert > EXT3_HAS_COMPAT_FEATURE to be > > ( le32_to_cpu(EXT3_SB(sb)->s_es->s_feature_compat) & (mask) )
Of course that's less efficient though since "mask" is probably constant.. so now the endian conversion changed from compile-time to run-time.
Would something like
( ( EXT3_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask) ) != 0)
be enough to satisfy sparse?
-Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |