Messages in this thread Patch in this message | | | From | Alexey Dobriyan <> | Subject | Re: [PATCH] ext3: Fix sparse -Wbitwise warnings. | Date | Tue, 15 Feb 2005 20:13:21 +0200 |
| |
On Tuesday 15 February 2005 16:12, Stephen C. Tweedie wrote: > On Tue, 2005-02-15 at 10:46, Alexey Dobriyan wrote: > > > - if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, > > - ~EXT3_FEATURE_RO_COMPAT_SUPP))) { > > + if ((ret = le32_to_cpu(EXT3_HAS_RO_COMPAT_FEATURE(sb, > > + ~EXT3_FEATURE_RO_COMPAT_SUPP)))) { > > NAK.
Argh... stupid me. super.c part should be just:
--- linux-2.6.11-rc4/fs/ext3/super.c.orig 2005-02-15 20:01:52.000000000 +0200 +++ linux-2.6.11-rc4/fs/ext3/super.c 2005-02-15 20:02:47.000000000 +0200 @@ -2106,6 +2106,7 @@ static int ext3_remount (struct super_bl ext3_mark_recovery_complete(sb, es); } else { __le32 ret; + int ret1; if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP))) { printk(KERN_WARNING "EXT3-fs: %s: couldn't " @@ -2122,8 +2123,8 @@ static int ext3_remount (struct super_bl */ ext3_clear_journal_err(sb, es); sbi->s_mount_state = le16_to_cpu(es->s_state); - if ((ret = ext3_group_extend(sb, es, n_blocks_count))) - return ret; + if ((ret1 = ext3_group_extend(sb, es, n_blocks_count))) + return ret1; if (!ext3_setup_super (sb, es, 0)) sb->s_flags &= ~MS_RDONLY; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |