lkml.org 
[lkml]   [2005]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [PATCH] Add memcpy32 function
On Thu, Dec 22, 2005 at 09:49:43PM -0500, Dave Jones wrote:
> On Thu, Dec 22, 2005 at 05:35:59PM -0800, Bryan O'Sullivan wrote:
> > In response to the comments that followed Roland Dreier posting our
> > InfiniPath driver for review last week, we've been making some cleanups
> > to our driver code.
> >
> > As our chip requires 32-bit accesses, we need a copy function that
> > guarantees operating in such terms. It was suggested that we make this
> > generic, with arch-specific optimised versions.
> >
> > This patch introduces the generic copy routine, memcpy32. At Andrew's
> > suggestion, I've put it in a new header file, include/linux/io.h, which
> > I've styled after include/linux/string.h.
>
> io.h is a very generic sounding name for something that just houses
> a memcpy variant. What's wrong with calling a spade a spade,
> and using memcpy32.h ?

I think it belongs in string.h alongside memcpy, just for tradition's
sake. I don't think it belongs in a file named io.h, as it probably
has uses beyond I/O.

--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-23 18:21    [W:0.093 / U:1.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site