Messages in this thread | | | Date | Fri, 23 Dec 2005 12:14:53 -0600 | From | Matt Mackall <> | Subject | Re: [RFC] [PATCH] Add memcpy32 function |
| |
On Fri, Dec 23, 2005 at 05:42:28PM +0000, Christoph Hellwig wrote: > On Fri, Dec 23, 2005 at 11:16:28AM -0600, Matt Mackall wrote: > > > io.h is a very generic sounding name for something that just houses > > > a memcpy variant. What's wrong with calling a spade a spade, > > > and using memcpy32.h ? > > > > I think it belongs in string.h alongside memcpy, just for tradition's > > sake. I don't think it belongs in a file named io.h, as it probably > > has uses beyond I/O. > > Actually I think memcpy32 is not the thing pathscale wants. They want > memcpy_{to,from}_io32, because memcpy32 wouldn't be allowed to operate > on I/O mapped memory. I'd say back to the drawingboard.
Ahh, excellent point. We probably want something closer to iowrite32_rep and have it live in iomap.h. Perhaps iowrite32_copy?
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |