lkml.org 
[lkml]   [2005]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectinode_change_ok
Why are there no calls to inode_change_ok in nfs (on the client), but 
there are in most other filesytsems? Seems like there are some cases
in nfs in which a local permission check is done via a call to
nfs_permission which calls generic_permission ... if that is the case
why not do a call to inode_change_ok in similar cases?

For the case of cifs vfs, which is also missing this call - I was
thinking of adding something like:
if (!cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_PERM)
inode_change_ok(direntry->d_inode, attrs);
to fs/cifs/inode.c near the beginning of cifs_setattr. Although the
permissions (actually ACLs) are checked on the server during setattr
from cifs to Samba or cifs servers such as Windows, it is common for
convenience for users to mount with one id, rather than authenticating
each user (so that there are multiple smb uids) in which case the
permission check on setattr on the client can be important since
apparently the ".permission" entry point does not seem to get invoked in
the chown/chmod path.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-28 17:54    [W:0.135 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site