Messages in this thread | | | Date | Wed, 16 Nov 2005 14:47:11 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] libata error handling fixes (ATAPI) |
| |
On Wed, Nov 16 2005, Jeff Garzik wrote: > Jens Axboe wrote: > >I updated that patch, and converted IDE and SCSI to use it. See the > >results here: > > > >http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq > > > >The main change from the version posted last october is killing the > >'slightly' overdesigned completion queue hashing. > > Oh yeah: you shouldn't need to make scsi_retry_command() exported. > It's private to scsi, to just publish it in scsi_priv.h.
Oh right, I'll make that change. Thanks!
> Tangent: As part of my libata work, I'm thinking about un-exporting > scsi_finish_command(), and instead exporting scsi_eh_flush_done_q() and > scsi_eh_finish_cmd().
Sounds ok.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |