lkml.org 
[lkml]   [2005]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] libata error handling fixes (ATAPI)
    On 11/16/05, Jens Axboe <axboe@suse.de> wrote:

    > I updated that patch, and converted IDE and SCSI to use it. See the
    > results here:
    >
    > http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq

    I like it but:

    * "we know it's either an FS or PC request" assumption in
    ide_softirq_done() is really wrong
    * same with "uptodate = rq->errors"
    * blk_complete_request() is called with ide_lock hold but
    ide_softirq_done() also takes ide_lock - is this correct?

    "There's still room for improvement, as __ide_end_request() really
    could drop the lock after getting HWGROUP->rq (why does it need to
    hold it in the first place? If ->rq access isn't serialized, we are
    screwed anyways)."

    ide_preempt? and yes we are screwed...

    Bartlomiej
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-16 16:06    [W:1.020 / U:0.228 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean